Updates for backend v4.x compatibility and Pydantic v2.x #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l.py needed to be updated to mantain funcitonality. Marking a property as optional is no longer sufficient to make property truly optional. "Optional[<type>] = None" is now what is requried to make somthing truly optional. I have updated many of the different properties in the model.py in response to this change. Also some of the previously optional properties are no longer allowed by the v4.x backend, these have been marked as such however have not been removed because it is uncertain how this will affect backwards compatibility.
|
Thanks! This issue was addressed this week already in #46 and release in v0.4.2. I'll go ahead and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic has seriously changed its syntax in version 2.X and the model.py needed to be updated to maintain functionality. Marking a property as optional is no longer sufficient to make property truly optional. "Optional[] = None" is now what is required to make something truly optional. I have updated many of the different properties in the model.py in response to this change. Also some of the previously optional properties are no longer allowed by the v4.x backend, these have been marked as such however have not been removed because it is uncertain how this will affect backwards compatibility.