Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently is a lot of duplicate code in the client. And a lot of methods are mostly copies of each other. And other are implemented slightly differently even though they do equivalent work. This makes it hard to see similarities.
This PR unifies all interaction with the backend. This is mainly a refactor, but there are some behavioural changes:
datasets_create
now only returns the PID like all other creation functions.None
if the response is of type 'unknown id' and raise an exception otherwise (e.g. connection failure). Please check that the regular expression in_call_endpoint
is correct!This is not just about cleaning up code. It will also help us test downstream code by creating a fake client. This is easier with the refactor because
_call_endpoint
and_send_to_scicat
operate on structured data and not preformatted URLs and dictionaries. I will explain this in a separate issue.Unfortunately, test coverage is quite sparse, so I am not positive that all refactorings are correct. Please review carefully!
Question:
datasets_datablock_create
uses 'origdatablocks'. Should this be 'datablocks' instead?