Merge pull request #8 from dylanmcreynolds/easy_url

Easy url
SciCatProject · Jan 31, 2022 · b901bac · b901bac
2 parents 0b6f6dc + ec57a52
commit b901bac
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 106 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -2,14 +2,14 @@ default_language_version:
     python: python3
 repos:
   - repo: https://github.com/ambv/black
-    rev: stable
+    rev: 21.12b0
     hooks:
       - id: black
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v2.0.0
     hooks:
       - id: flake8
   - repo: https://github.com/kynan/nbstripout
-    rev: 0.3.9
+    rev: 0.5.0
     hooks:
       - id: nbstripout
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
diff --git a/pyscicat/client.py b/pyscicat/client.py
@@ -353,6 +353,17 @@ def get_datasets(self, filter_fields=None) -> List[Dataset]:
             return None
         return response.json()
 
+    # this method is future, needs testing.
+    # def update_dataset(self, pid, fields: Dict):
+    #     response = self._send_to_scicat(
+    #         f"{self._base_url}/Datasets", dataDict=fields, cmd="patch"
+    #     )
+    #     if not response.ok:
+    #         err = response.json()["error"]
+    #         logger.error(f'{err["name"]}, {err["statusCode"]}: {err["message"]}')
+    #         return None
+    #     return response.json()
+
 
 def get_file_size(pathobj):
     filesize = pathobj.lstat().st_size