Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check-code-quality): fix random publint failures #6

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

JoCa96
Copy link
Collaborator

@JoCa96 JoCa96 commented Dec 20, 2023

Installed publint as dependency to fix random pipeline failures.

The npx publint command downloads the publint package and runs it.
When it is run as a subcommand of pnpm -r --parallel it creates a race-condition between the parallel sub-processes downloading, installing and running publint.
We can easily resolve this by installing publint as a dependency and then it even runs without the need for npx.

@JoCa96 JoCa96 requested a review from larsrickert as a code owner December 20, 2023 16:21
@JoCa96 JoCa96 enabled auto-merge (squash) December 20, 2023 16:21
@JoCa96 JoCa96 merged commit a26b3b6 into main Dec 20, 2023
@JoCa96 JoCa96 deleted the jlc/fix-pipeline-publint-failure branch December 20, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants