refactor(OnyxAvatar): update default initials #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3eee875 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ae41f2a to
3eee875
Compare
JoCa96
reviewed
Jan 9, 2025
| @@ -6,18 +6,13 @@ const props = withDefaults(defineProps<OnyxAvatarProps>(), { | |||
| size: "48px", | |||
| }); | |||
|
|
|||
| const slots = defineSlots<{ | |||
There was a problem hiding this comment.
Please leave the option in to use a slot, then we don't have a breaking change
There was a problem hiding this comment.
Personally, I don't like having two ways for doing the same thing 🤔 Since slot also allows non-text content which we propably don't want to support, I'd prefer the propert.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2442
Previously the initials were taken from the first two words. Now they will be used from the first and last word.
Example for "John Middlename Doe":
The default slot has been removed in favor of the
initialsproperty to set custom initials.Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)