Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set Storybook dark mode correctly when switching VitePress theme #234

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

larsrickert
Copy link
Collaborator

The embedded Storybook component docs did not correctly switch to dark mode when the theme is toggled in VitePress.

Checklist

  • The added / edited code has been documented with JSDoc
  • All changes are documented in the documentation app (folder apps/docs)
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 95713ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@larsrickert larsrickert changed the title Fix/storybook theme docs: set Storybook dark mode correctly when switching VitePress theme Feb 1, 2024
@larsrickert larsrickert added bug Something isn't working or not shown correctly documentation Improvements or additions to documentation labels Feb 1, 2024
@larsrickert larsrickert enabled auto-merge (squash) February 1, 2024 14:58
@larsrickert larsrickert merged commit 92c2f96 into main Feb 1, 2024
3 checks passed
@larsrickert larsrickert deleted the fix/storybook-theme branch February 1, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or not shown correctly documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants