Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if username contains dash - #264

Closed
MichlMann opened this issue Jun 14, 2021 · 2 comments
Closed

Error if username contains dash - #264

MichlMann opened this issue Jun 14, 2021 · 2 comments
Labels
bug Something isn't working good first issue Issues/features involving simple code changes

Comments

@MichlMann
Copy link

example:

ssh-123456-username@domain.tld:22/asdf/asdsf

@SchoofsKelvin SchoofsKelvin added bug Something isn't working good first issue Issues/features involving simple code changes labels Jun 26, 2021
@SchoofsKelvin
Copy link
Owner

Quick glance makes it likely to be caused by this regex:

const CONNECTION_REGEX = /^((?<user>\w+)?(;[\w-]+=[\w\d-]+(,[\w\d-]+=[\w\d-]+)*)?@)?(?<host>[^@\\/:,=]+)(:(?<port>\d+))?(?<path>\/.*)?$/;

@SchoofsKelvin
Copy link
Owner

Fixed this issue (f05108a) which will be available in v1.20.2 of the extension, which will be released in about 10 minutes or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Issues/features involving simple code changes
Projects
None yet
Development

No branches or pull requests

2 participants