-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolves #978] Only install typing on Python<3.5 #979
Conversation
maybe should just remove typing altogether since sceptre currently only supports python 3.6 and 3.7? https://github.com/Sceptre/sceptre/blob/master/tox.ini#L2 |
Anything else needed to merge this? |
Makes sense |
@gabriellesc Do you have time to update this and fully remove @zaro0508 If Gabrielle is not able to get this updated, would you be willing to merge another PR to take care of this? And would there be a possibility of a bugfix release to include this update? This has become a hard blocker for me, as I cannot concurrently install |
yes @tarkatronic, willing to merge another PR for this however we are having difficulties with making a release at this moment. we are having discussions and trying to resolve in the #sceptre slack channel. |
Hi @tarkatronic , to work around module conflicts I run sceptre in a container. If this is something that would work for you in this case, have a look at https://github.com/craighurley/docker-sceptre |
Fully removed the |
This PR constrains the installation of `typing` to Python<3.5, since it is included in the standard library as of 3.5 and causes issues if installed alongside the standard library version.
This PR constrains the installation of `typing` to Python<3.5, since it is included in the standard library as of 3.5 and causes issues if installed alongside the standard library version.
This PR constrains the installation of
typing
to Python<3.5, since it is included in the standard library as of 3.5 and causes issues if installed alongside the standard library version.PR Checklist
[Resolve #issue-number]
.make test
) are passing.make lint
) checks.and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit