Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select the maximal available resolution using a dependecy property #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgherzog
Copy link

Specifying the desired width and height only works if the specified values correspond with available resolutions on the selected camera device. If the camera device doesn't support the specified desired width and height "any" resolution is taken; certainly not always the heighest availabe resolution.

This pull request provides a solution that selectes the highest available resolution. This option can be activated using a DependecyProperty in the VideoCaptureElement.

I just used a code-snipped from stackoverflow (https://stackoverflow.com/questions/7497559/how-to-list-camera-available-video-resolution) and included it in VideoCaptureElement. It would bossibly better fit into the VideoCapturePlayer class where it gets used in the SetVideoCaptureParameters method. But this method doesn't work there; the determined sourceFilter remains null.

Unfortunately I know too little about Direct3D to provide a proper solution; but still, I wanted to share my changes with you.

@sekulicb
Copy link

Does not work. When I loop through the result of all resolutions, max value is far far from what the camera supports. For example testing it on tables I get 1280x720 as max value, but the camera goes up to 2560x1440. Also I noticed a significant drop in quality compared to OpenCv wrappers. While images saved are in KB (200-300), with other libraries using same resolution brings about 1.5MB size picture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants