Add support for .NET 6 #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- Allow Windows consumers to use .NET 6 or later instead of .NET 4. Modifications ------------- - Move to the modern .csproj format with multi-targeting - Drop the .nuspec file and instead add properties directly to the csproj - Update to latest C++ platform toolset - Remove the unused settings files - Fix some miscellaneous warnings and compatibility issues - Set Visible to False for the DLLs in the targets file so they don't appear in Visual Studio and only get copied to output - Add SourceLink support and produce snupkg symbol packages - Embed the license and readme in the package Results ------- The NuGet package can now be produced by the .NET SDK 6 or greater with: ``` dotnet pack -c Release .\Source ``` The resulting package includes .NET 4.6.2 targets (oldest framework still in support by Microsoft) and .NET 6 targets.
|
Thanks for doing this. I made use of this in my hobby project! The upstream repo has not updated for years, so I wonder if this would be merged. If not, do consider a fork! Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow Windows consumers to use .NET 6 or later instead of .NET 4.
Modifications
buildTransitiveso that when WPFMediaKit is a transitive dependency the required DLLs are still copiedResults
The NuGet package can now be produced by the .NET SDK 6 or greater with:
The resulting package includes .NET 4.6.2 targets (oldest framework still in support by Microsoft) and .NET 6 targets.