Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently docker images are not versioned which can be an issue going further #62

Closed
preetkaran20 opened this issue Feb 22, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@preetkaran20
Copy link
Member

Is your feature request related to a problem? Please describe.
Docker images for VulnerableApp-facade just have 1 version latest. It should be the latest (whcih is unreleased) and specific tags for released versions.

For more information about the existing images: https://hub.docker.com/r/sasanlabs/owasp-vulnerableapp-facade/tags

How do we create images ?
we have a Github action for creating and pushing docker images: https://github.com/SasanLabs/VulnerableApp-facade/blob/main/.github/workflows/docker.yml

@preetkaran20 preetkaran20 added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2022
@preetkaran20
Copy link
Member Author

we have used github semantic versioning in Owasp VulnerableApp project. we can use similar thing here as well.

PR: SasanLabs/VulnerableApp#382

@merry-degaga
Copy link
Contributor

merry-degaga commented Aug 14, 2022

Karan, you can assign this to me.

I think I better understand the 'unreleased' tag. Because you want to manually create a GitHub release, by default, the most recent build/deploys will be tagged as 'unreleased'. Is this correct?

Then would you want functionality, that when someone does manually create a release, that will trigger a workflow, which can use the tag of that newly publish release and also add the 'latest' tag on DockerHub? Could this be a seperate/new issue?

Currently, with my most recent PR on the VulnerableApp repository, the latest docker build/deploy will be tagged with the version number and 'unreleased' tags.

@preetkaran20
Copy link
Member Author

preetkaran20 commented Aug 15, 2022

@merry-degaga we need the same functionality as we have in VulnerableApp repository and in both the repositories, we need an additional functionality which is to add the latest tag to docker hub and create a release as well and we will update the github release description manually with all the details.

Karan, you can assign this to me.

I think I better understand the 'unreleased' tag. Because you want to manually create a GitHub release, by default, the most recent build/deploys will be tagged as 'unreleased'. Is this correct?

Yes

Then would you want functionality, that when someone does manually create a release, that will trigger a workflow, which can use the tag of that newly publish release and also add the 'latest' tag on DockerHub? Could this be a seperate/new issue?

yes, this functionality is needed and that can be part of this ticket only.

Currently, with my most recent PR on the VulnerableApp repository, the latest docker build/deploy will be tagged with the version number and 'unreleased' tags.

yes, we need to change there as well and have a separate workflow that we will run manually for releasing the change and updating the latest tag.

preetkaran20 pushed a commit that referenced this issue Sep 8, 2022
* updated docker.yml workflow to automate semantic versioning, creating a tag for the repo, and push img to docker hub with unreleased and semver tags

* created workflow for automating release creation
@merry-degaga
Copy link
Contributor

Hi Karan, is it okay to close this issue?

Thank you

@preetkaran20
Copy link
Member Author

preetkaran20 commented Sep 10, 2022

Hi Karan, is it okay to close this issue?

Thank you

@merry-degaga closed the issue and thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants