2103 copy parameters from corfunc gives wrong values #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opy-parameters-from-corfunc-gives-wrong-values
rozyczko
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highlight of this pull request is that copy parameters from corfunc no longer gives "wrong" values.
I have disabled copy and paste for any perspectives that don't support it, this has required refactoring the copy and paste functionality in fitting. I have also done some tidying up of FittingUtilities but there is still plenty to do there.
As Corfunc never did, or attempted to support copy/paste, having enabled copy buttons was an oversight.
I'm not implementing anything new in this PR. For a proper implementation I will require a clear specification of what the right values should be. I'm not sure that there is a use case for copying and pasting everything like there is in fitting (note that individual fields can be copy and pasted). This enhancement should be a new issue / discussion.