Update to use latest bitcoinjs #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the changes are package-lock.json
|
|
i've checked the update quickly. so far so good. only one comment about the package-lock json: i know that it isn't perfect and that it isn't really the philosophy of the node js community but i feel more comfortable with pinned versions of dependencies in both package.json and package-lock.json. i'm going to run this update on a test environment to validate that everything is ok. |
|
tests ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated mocha because npm audit was reporting some vulnerabilities.
You can confirm package-lock is not malicious by checkout my branch, delete lockfile, then run npm install again, and git should show no diff from what your npm installed.
This BitcoinJS version supports Psbt. So in the future this will probably allow for some sort of multisig functionality? (maybe multiple people using same dojo can store partially signed PSBT on the dojo? idk. I am open to chat if you want)
Yay open source!
Closes #70