Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add testnet support to my-dojo #46

Merged
merged 1 commit into from
Aug 8, 2019
Merged

add testnet support to my-dojo #46

merged 1 commit into from
Aug 8, 2019

Conversation

kenshin-samourai
Copy link
Contributor

related to issue #18

@kenshin-samourai kenshin-samourai added enhancement New feature or request my-dojo Something related to my-dojo dev env something related to the dev process labels Aug 6, 2019
LaurentMT
LaurentMT approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@LaurentMT LaurentMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scenarii tested:

  • installation of a new dojo running on testnet
  • upgrade of an existing dojo running on mainnet.

Both seem ok.

@kenshin-samourai kenshin-samourai merged commit c6ccd4b into develop Aug 8, 2019
@LaurentMT LaurentMT deleted the feat_mydojo_testnet branch August 29, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentMT LaurentMT LaurentMT approved these changes

Assignees
No one assigned
Labels
dev env something related to the dev process enhancement New feature or request my-dojo Something related to my-dojo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenshin-samourai @LaurentMT