Drop unneeded reverseBuffer util method #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node.js a
Buffer
is also a subclass ofTypedArray
so there's no need for areverseBuffer
util method, you can just useTypedArray.prototype.reverse()
directly on aBuffer
instance.I haven't tested the PR because attempting to run tests or require
local-index-wrapper.js
just gives meError: Cannot find module '../../keys/'
.I'm not really familiar with Dojo, I was just looking at how the importer wrappers were implemented and saw this.