Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional block explorer #107

Merged
merged 7 commits into from
Dec 27, 2019
Merged

add optional block explorer #107

merged 7 commits into from
Dec 27, 2019

Conversation

kenshin-samourai
Copy link
Contributor

add an optional docker container packaging an instance of btc-rpc-explorer accessible through a dedicated tor hidden service.

based on @jochemin's project

@kenshin-samourai kenshin-samourai added enhancement New feature or request my-dojo Something related to my-dojo labels Dec 25, 2019
Copy link
Contributor

@LaurentMT LaurentMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests done:

  • fresh install (with and without the explorer activated)
  • upgrade from v1.3 (with and without the explorer activated)

Everything seems ok.

Note: Some parts of the UI seem "broken" with Tor browser (missing icons). Switching the security settings of Tor browser from Safest to Safer fixes the issue. A better long term solution would be that BTC RPC Explorer replaces SVG by PNG images.

Copy link
Contributor

@LaurentMT LaurentMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ok for commits: ad2c8f6, d285545 and fc96f2b (new installation & upgrade from v1.3)

@kenshin-samourai kenshin-samourai merged commit f153e14 into develop Dec 27, 2019
@kenshin-samourai kenshin-samourai deleted the feat_mydojo_explorer branch January 17, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request my-dojo Something related to my-dojo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants