Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Intelligent hotkey: long press PTT, short press toggle #69

Closed
deejayy opened this issue Jul 25, 2022 · 6 comments
Closed
Labels
enhancement New feature or request

Comments

@deejayy
Copy link

deejayy commented Jul 25, 2022

I'm not sure what else to add to the title, let me know if it needs clarification.

And of course thank you for considering!

@SaifAqqad SaifAqqad added the enhancement New feature or request label Jul 26, 2022
@SaifAqqad
Copy link
Owner

That's a great idea, I will definitely look into it

SaifAqqad added a commit that referenced this issue Aug 7, 2022
@SaifAqqad
Copy link
Owner

I've implemented this as 'Hybrid PTT' which is an option for PTT hotkeys
image

You can try it out in the dev build right now, if you have any questions or feedback, leave a comment below.

@deejayy
Copy link
Author

deejayy commented Aug 7, 2022

Kudos and thank you! I'll try it out! 🙏🏻

@deejayy
Copy link
Author

deejayy commented Aug 7, 2022

All right, checked, this is just pure awesomeness! I can't thank you enough.

Though this approach is best when the mic is off.

If the mic is on, I'm thinking that PTT functionality does not make too much sense. What's your opinion?
My concern is the there will be a slight (few milliseconds) mute when holding the button and it will turn the mic off at the end.

@SaifAqqad
Copy link
Owner

If the mic is on, I'm thinking that PTT functionality does not make too much sense. What's your opinion?

Right now, when the mic is on, it just works as a toggle. I think it makes sense, because in that case you would have used the hotkey as a toggle to be able to turn the mic on

@deejayy
Copy link
Author

deejayy commented Aug 8, 2022

You must be right, it's my way of thinking what might be misleading me. Thanks again for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants