Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FDS-2415] Fixes pytest CI Python Versions #1502

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

BWMac
Copy link
Collaborator

@BWMac BWMac commented Sep 13, 2024

While working on #1496, I noticed that our pytest runs in the CI workflow were only being executed in python 3.9, rather than in 3.9 AND 3.10. This is due to the actions/cache GH action not having a specification for which python version it should be using. This PR adds specific Python versions where necessary and also bumps up the versions of all GH actions we are using where needed (some were 2 or 3 versions behind the latest releases).

@BWMac BWMac marked this pull request as ready for review September 13, 2024 22:39
@BWMac BWMac requested a review from BryanFauble September 13, 2024 22:40
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link

Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@BWMac BWMac merged commit 017256b into develop Sep 15, 2024
7 checks passed
@BWMac BWMac deleted the bwmac/FDS-2415/fix_pytest_ci_python_versions branch September 15, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants