Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python client to 4.4.0 #1468

Merged
merged 1 commit into from
Aug 22, 2024
Merged

update python client to 4.4.0 #1468

merged 1 commit into from
Aug 22, 2024

Conversation

andrewelamb
Copy link
Contributor

@andrewelamb andrewelamb commented Aug 20, 2024 •
edited by jira bot
Loading

  • Fixes FDS-2263
  • Updates pythonclient to 4.4.0

@andrewelamb andrewelamb requested review from linglp and BryanFauble and removed request for BryanFauble August 20, 2024 22:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

BryanFauble
BryanFauble approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

linglp
linglp approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I also ran tests in test_api.py for this, and it seems like everything is passing except tests that failed in develop.

@andrewelamb andrewelamb merged commit 4591439 into develop Aug 22, 2024
6 checks passed
@andrewelamb andrewelamb deleted the FDS-2263-pythonclient branch August 22, 2024 16:17
@linglp linglp mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanFauble BryanFauble BryanFauble approved these changes

@linglp linglp linglp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewelamb @BryanFauble @linglp