fix: check existing great expectation suite before adding a new one #1458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://sagebionetworks.jira.com/browse/FDS-2155
Problem
Sometimes our GH workflows failed with great expectation suite error:
I think this problem occurred because the code adds an expectation suite without checking if it exists or not. See the original code below:
Link of failed GH action: https://github.com/Sage-Bionetworks/schematic/actions/runs/9893404399/attempts/1
Solution
Check if an expectation suite already exists before adding a new expectation suite. Based on the documentation here, you could use function
list_expectation_suite_name
to check if an expectation suite has been created. If it does, then we could retrieve the current suite (see documentation here)