fix: used environment variable to control tracing which allows tracing to be off during pytest run and normal API run #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
reviewed
Jul 2, 2024
BryanFauble
approved these changes
Jul 2, 2024
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related to: https://sagebionetworks.jira.com/browse/FDS-2177
Also related to: #1430
Changes
used environment variable to control tracing which allows tracing to be off during pytest run and normal API run
Note: The code was partly borrowed from synapse python client. See original code here: https://github.com/Sage-Bionetworks/synapsePythonClient/blob/develop/tests/integration/conftest.py
Tests
When I did
pytest -m "table_operations"orpytest -s tests/test_manifest.py::TestManifestGenerator, I am no longer seeing the warnings related to opentelemetry