-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set annotations in an async way when submitting a manifest -- new changes added #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Jul 17, 2024
@andrewelamb @GiaJordan I ran all tests again after merging with the latest develop, and they all passed. |
andrewelamb
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See original PR for context and benchmarking result: #1440
Changes:
Related to: https://sagebionetworks.jira.com/browse/FDS-2179
Related to: https://sagebionetworks.jira.com/browse/FDS-2181
format_row_annotation
to make sure that when entity id is in trash can, the function would return None and a warning will be logged. This is the current behavior. If not followed, integration test: test_upsertTable would fail.process_store_annos
to make sure that storing annotations is not triggered when annotations are emptyNote: format_row_annotations is still under tested because of technical debt in previous development of schematic (independent of async). Please see FDS 2138 for further testing and refactoring this function
Tests
I re-ran all the tests, including all the integration tests to make sure that they are all working.