-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop fds 364 pylint schema module #1393
Conversation
andrewelamb
commented
Apr 1, 2024
•
edited by jira
bot
Loading
edited by jira
bot
- Fixes FDS-364
- Pylints the schemas module
|
Checked via command line that I could convert the csv to jsonld, jsonld to jsonld and get the same file as the one stored on github. This worked. Running API tests as well. |
@mialy-defelice Just wanted to check in on this one. |
Hey did you reply to the comments? Im not seeing anything on my end. |
@mialy-defelice I don't see any comments.... |
@andrewelamb Oh thats strange. I had a bunch of questions. I can see them on my end, but no responses. I'll go ahead and approve bc they arent critical. |
@mialy-defelice What probably happened was that you added the comments, but didn't start the review. You'll see the comments, but noone else will , they will kinda of be like a draft. |