Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop fds 364 pylint schema module #1393

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

andrewelamb
Copy link
Contributor

@andrewelamb andrewelamb commented Apr 1, 2024

  • Fixes FDS-364
  • Pylints the schemas module

Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
43 New issues
0 Accepted issues

Measures
1 Security Hotspot
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mialy-defelice
Copy link
Contributor

Checked via command line that I could convert the csv to jsonld, jsonld to jsonld and get the same file as the one stored on github. This worked. Running API tests as well.

@andrewelamb
Copy link
Contributor Author

@mialy-defelice Just wanted to check in on this one.

@mialy-defelice
Copy link
Contributor

@mialy-defelice Just wanted to check in on this one.

Hey did you reply to the comments? Im not seeing anything on my end.

@andrewelamb
Copy link
Contributor Author

@mialy-defelice I don't see any comments....

@mialy-defelice
Copy link
Contributor

@andrewelamb Oh thats strange. I had a bunch of questions. I can see them on my end, but no responses. I'll go ahead and approve bc they arent critical.

@andrewelamb andrewelamb merged commit 3eaed83 into develop Apr 12, 2024
4 checks passed
@andrewelamb andrewelamb deleted the develop-FDS-364-pylint-schema-module branch April 12, 2024 22:31
@andrewelamb
Copy link
Contributor Author

@mialy-defelice What probably happened was that you added the comments, but didn't start the review. You'll see the comments, but noone else will , they will kinda of be like a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants