[bug fix] Fixed tests in test_api.py
#1352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two tests failing in
test_api
:test_get_dataset_files when full_path = False, file_names = None
The test failed because we changed the
walk
function in schematic. Since we changed thewalk
function to only include files and folders, tables are no longer in the output. I updated the tests to make sure that they now passtest_visualize_component
"Component" should be required, so I updated the
False
toTrue
Note: i found out this issue when doing a release of schematic v24.1.1
Related to: https://sagebionetworks.jira.com/browse/FDS-1604