-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue where the asset view was not being set correctly for operations involving manifest validation #1312
Fix an issue where the asset view was not being set correctly for operations involving manifest validation #1312
Conversation
Did some tests manually below through API:
I don't think this is expected because it doesn't show the values and rows that don't match. Also, this warning shouldn't be shown because in my test folder: https://www.synapse.org/#!Synapse:syn52737592, I have the same manifest. Another point to note: Another observation is that if we have three columns that have validation rules that could trigger cross manifest, it seems like we are calling |
Discussed in CR, to be addressed in FDS-1236
Discussed in CR, to be addressed in FDS-1237 cc: @AmyHeiser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GiaJordan ! i also confirmed that the submission is working fine.
@linglp thank you for reviewing! |
🎉 All dependencies have been resolved ! |
Add
asset_view
to/model/validate
andproject_scope
to/model/validate
andmodel/submit
so that cross manifest validation operations locate the correct resources.Depends on #1311 #1314
If you run any of the changed unit tests please delete the manifests that were uploaded to datasets
syn52656106
orsyn52656104
immediately to avoid causing other branches tests to fail. (Required until #1314 is merged)