Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update store/synapse.updateDB to take sg and se #1291

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

mialy-defelice
Copy link
Contributor

Fix to FDS-1043.

Updated FDS-1043 to take SchemaGenerator and SchemaExplorer. Updated all relevant downstream functions.

Copy link
Contributor

@GiaJordan GiaJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for all values of -mrt for record based and file based metadata

🚀

@mialy-defelice mialy-defelice marked this pull request as draft September 27, 2023 18:39
@mialy-defelice mialy-defelice self-assigned this Sep 27, 2023
@mialy-defelice mialy-defelice marked this pull request as ready for review September 27, 2023 18:53
@mialy-defelice
Copy link
Contributor Author

@GiaJordan I updated this PR, can you review again?

Copy link
Contributor

@GiaJordan GiaJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mialy-defelice mialy-defelice merged commit 606372e into develop Oct 10, 2023
@mialy-defelice mialy-defelice deleted the develop-pass-se-and-sg-to-updatedb-FDS-1043 branch October 10, 2023 19:41
@GiaJordan GiaJordan mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants