Update dependencies #34
Conversation
8a62732 to
647eb13
Compare
.travis.yml
Outdated
| @@ -9,6 +9,7 @@ env: | |||
| - LAMBDA_BUCKET="essentials-awss3lambdaartifactsbucket-x29ftznj6pqw" | |||
| - CFN_BUCKET="bootstrap-awss3cloudformationbucket-19qromfd235z9" | |||
| install: | |||
| - pip install -U 'importlib-metadata>=0.21' | |||
There was a problem hiding this comment.
pipenv is upgrading setuptools to a version that conflicts with the version of import-metadata installed in travis, and I think upgrading in travis is cleaner than adding import-metadata (and/or setuptools) to our Pipfile.
here's the bug we're running in to: pypa/setuptools#3293
There was a problem hiding this comment.
why would updating importlib-metadata in travis instance update the Pipefile.lock?
also why not try updating the travis distro or python version used in the distro?
There was a problem hiding this comment.
sorry, I missed the question about updating Pipfile.lock, but as I said in the commit message, I ran pipenv update --dev to update that file. and I was trying to avoid updating template.yaml and just create a minimal PR to unblock dependabot, but I suppose I might as well update the python version too
647eb13 to
955d431
Compare
A recent PR proposed by dependabot is failing to install dependencies in TravisCI. Update dependencies using `pipenv update --dev` to resolve the security alert, and update to python3.10 to avoid a conflict between `setuptools` and `importlib-metadata`. Also upgrade the OS to Bionic for an approximate kernel match with the lambda runtime environment. https://askubuntu.com/questions/517136/list-of-ubuntu-versions-with-corresponding-linux-kernel-version https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
955d431 to
a72cfa3
Compare
A recent PR proposed by dependabot is failing to install dependencies
in TravisCI. Update dependencies using
pipenv update --devto resolvethe security alert, and update to python3.10 to avoid a conflict
between
setuptoolsandimportlib-metadata.Also upgrade the OS to Bionic for an approximate kernel match with the
lambda runtime environment.
https://askubuntu.com/questions/517136/list-of-ubuntu-versions-with-corresponding-linux-kernel-version
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html