Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix tests and use SLE containers #77

Merged
merged 2 commits into from
Nov 7, 2023
Merged

ci: fix tests and use SLE containers #77

merged 2 commits into from
Nov 7, 2023

Conversation

yeoldegrove
Copy link
Collaborator

@yeoldegrove yeoldegrove commented Nov 7, 2023 •
edited
Loading

@yeoldegrove yeoldegrove added the ci label Nov 7, 2023
@yeoldegrove yeoldegrove self-assigned this Nov 7, 2023
@yeoldegrove yeoldegrove force-pushed the ci/codespell branch 2 times, most recently from c9b44c8 to e74d56b Compare November 7, 2023 07:41
@yeoldegrove yeoldegrove changed the title ci: fix codespell ignores ci: fix tests and use SLE containers Nov 7, 2023
@yeoldegrove yeoldegrove requested a review from arbulu89 November 7, 2023 08:22
arbulu89
arbulu89 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me using SLEs containers to test simple python code is an overkill.
I would leave as it was, as we already do the testing in SLES during builds in OBS.
Anyway, as you are the maintaner of the package, up to you hehe

.github/workflows/shaptools-ci.yml
steps:
- name: Auth to SCC and minimal dependencies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need all this stuff?
I mean, I understand that testing in SLEs is good, but we already do this in OBS (where we run this exact tests as far as I know).
In my opinion it is an overkill, and a hussle, as wee need to maintain secrets now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I will keep it this way for now.
It is the same CI we currently use for https://github.com/SUSE/salt-shaptools.
Trimming it down can be done another time.

@yeoldegrove yeoldegrove merged commit 4dce453 into main Nov 7, 2023
@yeoldegrove yeoldegrove deleted the ci/codespell branch November 7, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

Assignees

@yeoldegrove yeoldegrove

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeoldegrove @arbulu89