Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt no longer vendors six (>=salt-3006.0) #93

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Salt no longer vendors six (>=salt-3006.0) #93

merged 2 commits into from
Jul 17, 2023

Conversation

yeoldegrove
Copy link
Collaborator

Salt no longer vendors six (>=salt-3006.0)
saltstack/salt#63874

  • Use shipped library with older salt releases and use packaged version in newer version.

This is related to SUSE/ha-sap-terraform-deployments#908

@yeoldegrove yeoldegrove added the bug Something isn't working label Jul 11, 2023
@yeoldegrove yeoldegrove requested a review from arbulu89 July 11, 2023 15:19
@yeoldegrove yeoldegrove self-assigned this Jul 11, 2023
Copy link
Collaborator

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeoldegrove Codewise looks good!
Please, give a round of testing in SLE version where we have salt 3004 or older and salt 3006.

@yeoldegrove
Copy link
Collaborator Author

I ran the code on the following setups successfully:

  • SLES 12 SP5 - salt-3000-74.1
  • SLES 15 SP4 - salt-3006.0-150400.8.34.2
  • SLES 15 SP4 - salt-3004-150400.8.8.1
  • SLES 15 SP5 - salt-3006.0-150500.4.9.2
  • SLES 15 SP5 - salt-3005.1-150500.2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants