Include name argument in service account cmd #53
Conversation
|
There are two paths for the account id issue. This one uses |
|
Sounds like we will make the change in schema https://github.com/neuvector/neuvector-helm/blob/master/charts/core/values.schema.json#L188 so we can drop the |
|
@bear454 dropped the set string change since change will happen in upstream chart. This is ready for review and merge. |
| @@ -50,6 +50,7 @@ eksctl create iamserviceaccount \ | |||
| --namespace neuvector --cluster $CLUSTER_NAME \ | |||
| --role-name $ROLE_NAME --role-only \ | |||
| --attach-policy-arn 'arn:aws:iam::aws:policy/AWSMarketplaceMeteringFullAccess' \ | |||
| --name csp \ | |||
There was a problem hiding this comment.
Sorry for the late review, can you explain how this attribute is used?
There was a problem hiding this comment.
It's the name of the ServiceAccount in K8s that gets attached to the container role. https://github.com/neuvector/neuvector-helm/blob/master/charts/core/values.yaml#L51
And use explicit set string option in helm install to handle the account id number as a string.