Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/active learning pce #212

Merged
merged 12 commits into from
Apr 26, 2023
Merged

Conversation

NovakLBUT
Copy link
Contributor

@NovakLBUT NovakLBUT commented Apr 18, 2023

Active learning for polynomial chaos expansion
New active learning class for PCE

Description

Added a new class for adaptive sequential sampling based on Theta criterion for PCE. Two additional functions in PCE class for standardization of a sample and corresponding PDF.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@NovakLBUT NovakLBUT marked this pull request as ready for review April 18, 2023 15:56
@NovakLBUT NovakLBUT requested a review from dimtsap April 18, 2023 15:56
Copy link
Contributor

@dimtsap dimtsap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please add unit test and documnetation for the new methods and classes before proceding to merge

src/UQpy/sampling/ThetaCriterionPCE.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.6% 95.6% Coverage
0.0% 0.0% Duplication

@dimtsap dimtsap merged commit 888209e into Development Apr 26, 2023
@dimtsap dimtsap deleted the feature/Active_Learning_PCE branch April 28, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants