Added default value if exists #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json-derulo
requested changes
Sep 4, 2017
json-derulo
reviewed
Sep 4, 2017
| Matcher m = Pattern.compile(Regex.GETMETHODHEADERPARAMETER).matcher(paramUnformatted); | ||
| while (m.find() && isDefaultValue) { | ||
| List<String> paramUnformattedTest = new ArrayList<String>(); | ||
| paramUnformattedTest.add(m.group()); |
There was a problem hiding this comment.
Die Liste paramUnformattedTest enthält höchstens einen Wert. Du kannst mit dem String direkt arbeiten.
json-derulo
reviewed
Sep 4, 2017
| paramUnformattedTest.add(m.group()); | ||
| for (int i = 0; i < paramUnformattedTest.size(); i++) { | ||
| if (paramUnformattedTest.get(i).contains("@DefaultValue")) { | ||
| createMapFromParameters(paramUnformatted); |
There was a problem hiding this comment.
Die Methode gibt eine Map zurück, der Rückgabewert wird aber nie verwendet.
json-derulo
reviewed
Sep 4, 2017
| String param = paramUnformatted.replaceAll("[\\s]*" + Regex.ANNOTATION + "[\\s]*", "").trim(); | ||
|
|
||
| List<String> defaultValue = new ArrayList<String>(); |
There was a problem hiding this comment.
Namensgebung: Damit man direkt sehen kann, dass es mehrere Werte sind, lieber umbenennen zu defaultValues
json-derulo
reviewed
Sep 4, 2017
| if (isDefaultValue) { | ||
| parameter.setLocation("query"); | ||
| // parameter.setType(type); | ||
| for (int i = 0; i < defaultValue.size(); i++) { |
There was a problem hiding this comment.
Ich bevorzuge for-Schleifen mit der Doppelpunkt-Schreibweise
for (String value: defaultValue) { }
json-derulo
reviewed
Sep 4, 2017
| parameter.setLocation("query"); | ||
| // parameter.setType(type); | ||
| for (int i = 0; i < defaultValue.size(); i++) { | ||
| parameter.setDefaultValue(defaultValue.get(i)); |
There was a problem hiding this comment.
Aktuell ist es so, wenn es mehrere defaultValues gibt, wird nur das letzte genommen.
Kann es überhaupt mehrere geben?
json-derulo
requested changes
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.