Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devxsby
approved these changes
Dec 22, 2022
| @@ -0,0 +1,41 @@ | |||
| // | |||
| // File.swift | |||
|
|
||
| import Foundation | ||
|
|
||
| // MARK: - Welcome |
| // | ||
|
|
||
| import Foundation | ||
| import UIKit |
Comment on lines
+226
to
+233
| case .success(let result): | ||
| let status = result.statusCode | ||
| if status >= 200 && status < 300 { | ||
| do { | ||
| self.bookListResponse = try result.map(BookListResponseDTO?.self)! | ||
| guard let pickArray = self.bookListResponse?.data.pick else { return } | ||
| guard let topicArray = self.bookListResponse?.data.topic else { return } | ||
| self.hotBookContainerView.topicViewArray = topicArray |
Comment on lines
+218
to
+220
| var pickArray: [BookListDataArray] = [] | ||
| var topicArray: [BookListDataArray] = [] | ||
| var bookListResponse: BookListResponseDTO? |
Comment on lines
+246
to
+250
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
|
|
||
| bookListAPI() | ||
| } |
There was a problem hiding this comment.
life cycle 관련 코드는 위로 올려주세요..~
| @@ -10,6 +10,8 @@ import SnapKit | |||
| import Then | |||
|
|
|||
| class HotBookCVC: UICollectionViewCell { | |||
|
|
|||
| static let identifier = "HotBookCVC" | |||
There was a problem hiding this comment.
여기 이거 선언하지말구 제가 util에 만들어놓은 classname으루 쓰면 될 것 같아여
Comment on lines
+47
to
+56
| DispatchQueue.global().async { [weak self] in | ||
| let url = URL(string: model.cover) | ||
| if let data = try? Data(contentsOf: url!) { | ||
| if let image = UIImage(data: data) { | ||
| DispatchQueue.main.async { | ||
| self?.bookSampleImageView.image = image | ||
| } | ||
| } | ||
| } | ||
| } |
Comment on lines
+57
to
+63
| // let url = URL(string: model.cover) | ||
| // do { | ||
| // let data = try Data(contentsOf: url!) | ||
| // bookSampleImageView.image = UIImage(data: data) | ||
| // } catch (let error) { | ||
| // print("err") | ||
| // } |
Comment on lines
+64
to
+65
| bookNameLabel.text = model.name | ||
| bookIntroLabel.text = model.pickDescription |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
책리스트 api를 연결해보았습니다.
🚨참고 사항
미완성이지만,, 서버가 연결되긴 했어요..
📸 스크린샷
📟 관련 이슈