Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect directly to kafka brokers using new client closes #666 #691

Merged
merged 28 commits into from
Jun 30, 2017
Merged

Connect directly to kafka brokers using new client closes #666 #691

merged 28 commits into from
Jun 30, 2017

Conversation

hyperlink
Copy link
Collaborator

@hyperlink hyperlink commented Jun 19, 2017 •
edited
Loading

Closes #666

@hyperlink hyperlink force-pushed the kafka-client branch 2 times, most recently from ecb3983 to a321b31 Compare June 22, 2017 13:51
hyperlink added 24 commits June 22, 2017 21:48
@hyperlink
Add initial kafka client and test
3633607
@hyperlink
Expose KafkaClient
2ab8fbf
@hyperlink
Add doc for new KafkaClient
cee3b41
@hyperlink
Add TimeoutError to broker connect
d37ba7b
@hyperlink
Add more test to verify timeout
bbd5278
@hyperlink
Add support to timeout kafka request
0e231de
@hyperlink
Attempt to connect to a list of initial kafka hosts
0bf7198
@hyperlink
Connect to set of brokers with retries
70416ed
@hyperlink
consumerGroup can use kafkaClient
df6972d
@hyperlink
ConsumerGroup should throw if migration is turned on and KafkaClient …
f23fc14 
…is used
@hyperlink
double check brokerMetadata after connect
b6b5a49
@hyperlink
add setter for brokerMetadata
dc6edb6
@hyperlink
Clarify when ready is emitted in KafkaClient
ee1fd9a
@hyperlink
Add broker wrapper helper
976020f
@hyperlink
add getAvailableBroker method and updateMetadata should update broker…
74f4248 
…Metadata as well
@hyperlink
formatting
9d56854
@hyperlink
Added method to refresh the broker metadata
2e9252b
@hyperlink
Add to ConsumerGroup using Kafka Client to rebalance tests
3555a8f
@hyperlink
remove console.log
32f4a16
@hyperlink
Call close on test Kafka Clients
81d1ff2
@hyperlink
formatting
83eeddb
@hyperlink
add hooks for refreshMetadata for KafkaClient
9c45d3a
@hyperlink
Check instance of Client for HighLevelConsumer enforcing only origina…
e832d6d 
…l Client
@hyperlink
Allow closing the client to abort connection retries
c952bb9
@hyperlink hyperlink merged commit 27ad9f1 into master Jun 30, 2017
@hyperlink hyperlink deleted the kafka-client branch June 30, 2017 23:58
@crzidea
Copy link
Member

crzidea commented Jul 5, 2017

Good job!

This was referenced Jul 10, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haio haio Awaiting requested review from haio

@carlessistare carlessistare Awaiting requested review from carlessistare

@crzidea crzidea Awaiting requested review from crzidea

Assignees
No one assigned
Labels
kafka client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyperlink @crzidea