Fix bug in Fetch earliest offsets #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etch-earliest-offsets
…etch-earliest-offsets
…tch-earliest-offsets
-call proper fetch method
hyperlink
requested changes
Jan 23, 2017
|
@hyperlink requested changes made but your tests fail due to the changes |
|
Right, those tests should fail because they rely on the ready var being changed. Can you update the test to emit |
hyperlink
requested changes
Jan 23, 2017
| setTimeout(function () { | ||
| this.fetch(payloads, cb); | ||
| }.bind(this), 100); | ||
| this.once('ready', () => this.fetch(payloads, cb).bind(this)); |
There was a problem hiding this comment.
We don't need a bind here since we're using fat arrow.
| setTimeout(function () { | ||
| this.commit(groupId, payloads, cb); | ||
| }.bind(this), 100); | ||
| this.once('ready', () => this.commit(groupId, payloads, cb).bind(this)); |
| setTimeout(function () { | ||
| this.fetchCommits(groupId, payloads, cb); | ||
| }.bind(this), 100); | ||
| this.once('ready', () => this.fetchCommits(groupId, payloads, cb).bind(this)); |
|
@hyperlink, good to go? |
hyperlink
approved these changes
Jan 30, 2017
|
Published as 1.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when offset isnt ready need to call proper method in setTimeout.