remove zookeeper #1163
Merged
remove zookeeper #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove and update tests using deprecated zookeeper client remove Client support from ConsumerGroup, remove HLC migrator Update to using kafkaClient in tests delete zookeeper.js update high level producer example Fallback to using baseClient sendFetchRequest when not using ConsumerGroup Update producer example Update client reference in proxyquires specify kafkaHost for SSL clients formatting fix host remove mock zookeeper remove highLevelConsumer
ahmedlafta
reviewed
Apr 5, 2019
| this.committing = false; | ||
| }.bind(this), | ||
| this.options.autoCommitIntervalMs | ||
| ).unref(); |
There was a problem hiding this comment.
Hey @hyperlink unref causes an error in an Electron environment.
Uncaught TypeError: setTimeout(...).unref is not a function
at ConsumerGroup.autoCommit
Is there an alternative way to clean up the timeout reference?
There was a problem hiding this comment.
I suppose we can check to see if unref is available and then call it if it's there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop zookeeper support from kafka-node
Update README
Remove HLC
Remove Client
Update examples
Update tests
Update typescript definitions