Add config entries and replica assignment to create topic #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for providing config entries and explicit replica assignment when creating new topics. The existing create topic implementation has been cleaned up a bit, as it didn't make use of the existing API support setup (it was fixed to protocol version 1). As part of the cleanup, version 0 and 1 of the request is now supported. The send controller request was also cleaned up a bit. A new function sendRequestToBroker provides a more robust way to send requests to a specific broker now.
hyperlink
reviewed
Jan 7, 2019
|
@hyperlink updated PR based on your comments, let me know of any other suggestions :-) |
hyperlink
approved these changes
Jan 8, 2019
|
Thanks @jlandersen ! |
Thanks for the merge! Appreciate it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for providing config entries and explicit replica assignment
when creating new topics.
The existing create topic implementation has been cleaned up a bit,
as it didn't make use of the existing API support setup (it was fixed to protocol version 1).
As part of the cleanup, version 0 and 1 of the request is now supported.
The send controller request was also cleaned up a bit. A new function
sendRequestToBrokerprovides a more robust way to send requests to a specific broker now.
Create Topic tests now skips version 0.10. The new describe configs request is used to validate config entries. This request is supported from 0.11+.
This addition is backwards compatible.