Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When do you plan to support compression (gzip, snappy) #3

Closed
xiaojun789 opened this issue Dec 5, 2013 · 1 comment
Closed

When do you plan to support compression (gzip, snappy) #3

xiaojun789 opened this issue Dec 5, 2013 · 1 comment

Comments

@xiaojun789
Copy link

In our case, we want to have compression feature, do you have plan to support this soon. Thanks~!

@haio
Copy link
Member

haio commented Dec 5, 2013

Maybe it can't be done soon, sorry for that. We very appreciate the PR about this feature. Thanks.

@haio haio closed this as completed Dec 5, 2013
shaikh-shahid added a commit to shaikh-shahid/kafka-node that referenced this issue Oct 24, 2016
Fixes for build SOHU-Co#3.
hyperlink pushed a commit that referenced this issue Oct 26, 2016
* Kafka topics should not contain special characters

This is my observation while playing with createTopics function. I later realised that topic names which I am creating contains special characters such as :,// etc which is causing the issue. I tried without them and it works. It does work with other number and string combinations so no test required for that.

Hope this PR is help.

* Update client.js

Fixes for build failure #1.

* Update client.js

Fixed for build #2.

* Update client.js

Fixes for build #3.

* Validating the topics using util function

* Build fix

* Update client.js

Updating the name of function as per changes in pull req no 17.

* Handling async nature of validation.

Build fix.

* Update client.js

Build fix.

* Update client.js

For build fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants