-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update #14
Feature/update #14
Conversation
0da08b4
to
d927f2e
Compare
Sorry had an unnecessary change in the csproj, cleaned it up. |
All the lines of code that now have discard assignments have been changed to use spaces instead of I'll do a full review on monday. Thanks for the PR though! :) |
Ok give me a second. Glad you saw that, as I usually prefer tabs too. Must be the new install having other standard settings. |
d927f2e
to
3410741
Compare
So configuring my fresh install indeed helped. |
I'd put just the essentials in the editorconfig for now - tabs, size 4, encoding utf8. |
Since I'm updating anyway: Should I also update nuget dependencies and the assembly/nuget version? Would do that in another commit. |
Yeah, may as well update that too. |
I updated the major version, since this is a breaking change to people not on netstandard21/core3. had to make some adjustments, since AngleSharp changed some namespaces and API names. |
Man I would prefer having some automatic tests now, since I don't have an actually working bot yet 😅. |
Yeah, automated testing was something I wanted to add as well. However, most functions require authentication to work; and failing to see a clean way of handling that, I just left it. :D The sample code is really the only thing I can point you towards wrt your broken bot. As I mentioned before, feel free to open an issue if you need help. Anyway, the PR looks fine. Thanks for your contribution! |
Basically the first commit is only updating the library to netstandard21 and the examples to core3.
The second commit applies some code style recommended by VS, i.e. using the new using declaration. I can remove this if you like, this just kinda happened.