Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for comments on other sites than SO, added placeholders, fixed some bugs #281

Closed
wants to merge 11 commits into from
Closed

Added support for comments on other sites than SO, added placeholders, fixed some bugs #281

wants to merge 11 commits into from

Conversation

fastnlight0
Copy link
Contributor

@fastnlight0 fastnlight0 commented Jan 17, 2024 •
edited
Loading

Added support for comments and Answer related NAA options for sites other than Stack Overflow.

In addition, similar to AutoReviewComments, I added 3 placeholders:

Placeholder Description Example
%SITENAME% The site name Stack Overflow, Super User, Physics Stack Exchange
%SITEURL% The domain of the current site stackoverflow.com, money.stackexchange.com
%OP% The author of the question/answer fastnlight

I've also fixed a bug where if a user was recognized in a collective, AdvancedFlagging would believe their answer was actually a question.

@fastnlight0 fastnlight0 mentioned this pull request Jan 17, 2024
Closed
@fastnlight0 fastnlight0 changed the title Added support for comments on other sites than SO, added placeholders Added support for comments on other sites than SO, added placeholders, fixed some bugs Jan 18, 2024
fastnlight0 and others added 3 commits January 18, 2024 11:53
@fastnlight0
Fixed bug
b6dc3e1
@fastnlight0
Added "Stack Exchange" to site names that need it.
23e3fa8 
Some sites (eg. Stack Overflow and Super User) aren't affected, but sites like Physics Stack Exchange will be.
@fastnlight0
Fixed warnings
2327412
double-beep
double-beep requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@double-beep double-beep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I will test the changes in the weekend.

src/popover.ts Outdated Show resolved Hide resolved
@double-beep
Copy link
Member

Hmm... I'm reluctant to approve this. IIRC, the reason that adding answer-related comments via the AF menu on non-SO sites was disabled is because of this Charcoal policy:

You should not leave comments under a post reported by SmokeDetector, unless you are otherwise familiar with that Stack Exchange site. In general, that means you participate on the site for more than responding to SmokeDetector reports and/or viewing a few Hot Network Questions.

@fastnlight0
Copy link
Contributor Author

The primary reason I allowed comments on all sites is so AF isn't a SO only userscript, but could be used by regulars of other sites. I fully understand why it was disabled in the first place. If you want me to disable it again, please let me know.

@double-beep
Copy link
Member

I'm sorry for the delay in responding. Since I've rewritten some parts of the code this PR modifies, could you open a new PR with your changes? Thanks!

@double-beep double-beep closed this Jun 3, 2024
@fastnlight0
Copy link
Contributor Author

@double-beep Done! #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@double-beep double-beep double-beep requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fastnlight0 @double-beep