Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modality required for all extractions #2045

Merged
merged 29 commits into from
Dec 11, 2024
Merged

Conversation

rkm
Copy link
Member

@rkm rkm commented Dec 9, 2024

Proposed Changes

This shouldn't be a noticeable change in any case I'm aware of, since we already split extractions by modality anyway.

This also enables upcoming changes on the extraction pool feature.

Notes:

  • The Modality / Modalities property already existed on some messages, but it has now been pulled up to the base class and inherited by all
  • Added ExtractionRequestFulfillerFactory to replace the troublesome ObjectFactory reflection pattern
  • Tidied FromCataloguesExtractionRequestFulfiller and removed unnecessary protected/virtual modifiers

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 83.82353% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.48%. Comparing base (98d803f) to head (9b47aec).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...croservices/CohortExtractor/CohortExtractorHost.cs 55.55% 2 Missing and 2 partials ⚠️
...ohortExtractor/RequestFulfillers/QueryToExecute.cs 73.33% 0 Missing and 4 partials ⚠️
...estFulfillers/ExtractionRequestFulfillerFactory.cs 60.00% 1 Missing and 1 partial ⚠️
...lications/ExtractImages/ExtractionMessageSender.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2045      +/-   ##
==========================================
- Coverage   65.67%   65.48%   -0.20%     
==========================================
  Files         183      181       -2     
  Lines        6576     6530      -46     
  Branches      973      963      -10     
==========================================
- Hits         4319     4276      -43     
+ Misses       1966     1963       -3     
  Partials      291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm force-pushed the change/require-modality branch from 5fbcefa to 8596d14 Compare December 11, 2024 11:48
@rkm rkm force-pushed the change/require-modality branch from 2b4391a to b0769fd Compare December 11, 2024 15:28
@rkm rkm force-pushed the change/require-modality branch from b0769fd to 759e12e Compare December 11, 2024 15:43
@rkm rkm force-pushed the change/require-modality branch from 7fa2efb to c16b1f7 Compare December 11, 2024 16:18
@rkm rkm marked this pull request as ready for review December 11, 2024 16:34
@rkm rkm requested a review from jas88 December 11, 2024 16:34
@jas88 jas88 merged commit f5a6b51 into main Dec 11, 2024
19 checks passed
@jas88 jas88 deleted the change/require-modality branch December 11, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

populate modality in ExtractFileMessage
2 participants