-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make modality required for all extractions #2045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into change/require-modality
…into change/require-modality
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2045 +/- ##
==========================================
- Coverage 65.67% 65.48% -0.20%
==========================================
Files 183 181 -2
Lines 6576 6530 -46
Branches 973 963 -10
==========================================
- Hits 4319 4276 -43
+ Misses 1966 1963 -3
Partials 291 291 ☔ View full report in Codecov by Sentry. |
rkm
force-pushed
the
change/require-modality
branch
from
December 11, 2024 11:48
5fbcefa
to
8596d14
Compare
rkm
force-pushed
the
change/require-modality
branch
from
December 11, 2024 15:28
2b4391a
to
b0769fd
Compare
rkm
force-pushed
the
change/require-modality
branch
from
December 11, 2024 15:43
b0769fd
to
759e12e
Compare
rkm
force-pushed
the
change/require-modality
branch
from
December 11, 2024 16:18
7fa2efb
to
c16b1f7
Compare
jas88
reviewed
Dec 11, 2024
src/SmiServices/Microservices/CohortExtractor/CohortExtractorHost.cs
Outdated
Show resolved
Hide resolved
jas88
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This shouldn't be a noticeable change in any case I'm aware of, since we already split extractions by modality anyway.
This also enables upcoming changes on the extraction pool feature.
Notes:
Modality
/Modalities
property already existed on some messages, but it has now been pulled up to the base class and inherited by allExtractionRequestFulfillerFactory
to replace the troublesome ObjectFactory reflection patternFromCataloguesExtractionRequestFulfiller
and removed unnecessary protected/virtual modifiersTypes of changes
[skip ci]
Checklist
By opening this PR, I confirm that I have:
@SMI/Reviewers
teamIssues
ExtractFileMessage
#1751