Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extraction rate limiting #1945

Merged
merged 11 commits into from
Sep 26, 2024
Merged

Feature/extraction rate limiting #1945

merged 11 commits into from
Sep 26, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Sep 26, 2024

Proposed Changes

Add a publish timeout backoff mechanism to ProducerModel, allowing control over message publishing timeout behaviour. This can be enabled by setting BackoffProviderType in any ProducerOptions config. Currently implemented types are:

  • StaticBackoffProvider (1 minute flat timeout)
  • ExponentialBackoffProvider (1 minute initial, doubling after each timeout)

We can make the timeout values and limits configurable in a future PR.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.30%. Comparing base (d2732c0) to head (0f55ea5).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...ervices/Common/Messaging/BackoffProviderFactory.cs 62.50% 2 Missing and 1 partial ⚠️
src/SmiServices/Common/Messaging/ProducerModel.cs 88.88% 0 Missing and 1 partial ⚠️
...Services/Common/Messaging/StaticBackoffProvider.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
+ Coverage   64.09%   64.30%   +0.20%     
==========================================
  Files         177      180       +3     
  Lines        6529     6564      +35     
  Branches      969      977       +8     
==========================================
+ Hits         4185     4221      +36     
+ Misses       2057     2056       -1     
  Partials      287      287              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm marked this pull request as ready for review September 26, 2024 16:22
@rkm rkm enabled auto-merge (rebase) September 26, 2024 16:25
@rkm rkm requested a review from a team September 26, 2024 16:25
@rkm rkm merged commit 454ad5e into main Sep 26, 2024
19 checks passed
@rkm rkm deleted the feature/extraction-rate-limiting branch September 26, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants