Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coverage reporting #1901

Merged
merged 10 commits into from
Aug 7, 2024
Merged

fix coverage reporting #1901

merged 10 commits into from
Aug 7, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Aug 7, 2024

Proposed Changes

coverlet.msbuild was becoming buggy and hard to deal with, so we switch to the dotnet-coverage (Microsoft.CodeCoverage) tool which now seems stable and can generate the same report format.

This also uploads the coverage report as a build artifact to make it easier to debug CI runs.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

@rkm rkm marked this pull request as ready for review August 7, 2024 10:11
@rkm rkm requested a review from a team August 7, 2024 10:11
@rkm rkm enabled auto-merge August 7, 2024 10:19
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (8dfa2c0) to head (3f7e43c).

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #1901       +/-   ##
==========================================
+ Coverage   0.00%   80.79%   +80.79%     
==========================================
  Files        177      309      +132     
  Lines       6548    15397     +8849     
  Branches     898     1366      +468     
==========================================
+ Hits           0    12440    +12440     
+ Misses      6548     2541     -4007     
- Partials       0      416      +416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm merged commit 95dc73f into main Aug 7, 2024
19 checks passed
@jas88 jas88 deleted the fix-coverage branch August 7, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants