Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop assuming we only run on MySQL #1889

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Stop assuming we only run on MySQL #1889

merged 3 commits into from
Jul 29, 2024

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Jul 29, 2024

Proposed Changes

Handle database exceptions more generally, not just MySqlExceptions.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Closes #1884

@jas88 jas88 requested a review from rkm July 29, 2024 14:19
@jas88 jas88 enabled auto-merge (squash) July 29, 2024 14:21
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (7c407ff) to head (a60869c).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1889   +/-   ##
=======================================
  Coverage   60.96%   60.96%           
=======================================
  Files         177      177           
  Lines        6559     6559           
  Branches      898      898           
=======================================
  Hits         3999     3999           
  Misses       2289     2289           
  Partials      271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jas88 jas88 merged commit 5eb780c into main Jul 29, 2024
19 checks passed
@jas88 jas88 deleted the feature/dbagnostic branch July 29, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exception handling assumes MySQL
2 participants