add MSBuildTreatWarningsAsErrors

[rkm]

Proposed Changes

Treat all warnings as errors. Individual warnings can be disabled if needed when a simple fix isn't available.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New Feature (non-breaking change which adds functionality)
• Breaking Change (fix or feature that would cause existing functionality to not work as expected)
• Documentation-Only Update (if none of the other choices apply)
  • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

• Reviewed the contributing guidelines for this repository
• Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
• Updated any relevant API documentation
• Created or updated any tests if relevant
• Created a news file
  • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
• Listed myself in the CONTRIBUTORS file 🚀
• Requested a review by the @SMI/Reviewers team

Issues

[jas88]

@rkm Mathnet.Numerics workaround PR now open for HicServices/SynthEHR, should be able to unblock this once that merges and releases.

[jas88]

@rkm Almost there now - once we pull in the next RDMP release that should all be fixed.

[rkm]

Needs #1956

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.82%. Comparing base (e10fcb2) to head (564ad43).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1847   +/-   ##
=======================================
  Coverage   64.82%   64.82%           
=======================================
  Files         181      181           
  Lines        6538     6538           
  Branches      963      963           
=======================================
  Hits         4238     4238           
  Misses       2017     2017           
  Partials      283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.