Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nunit api #1834

Merged
merged 10 commits into from
May 29, 2024
Merged

Feature/nunit api #1834

merged 10 commits into from
May 29, 2024

Conversation

jas88
Copy link
Member

@jas88 jas88 commented May 29, 2024

Proposed Changes

Update NUnit for v4 API as preparation for NUnit version bump required for later RDMP 8.1.x.

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

Closes #1734

@jas88 jas88 requested a review from rkm May 29, 2024 03:36
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.79%. Comparing base (1189483) to head (314d5f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1834   +/-   ##
=======================================
  Coverage   59.79%   59.79%           
=======================================
  Files         177      177           
  Lines        6328     6328           
  Branches      870      870           
=======================================
  Hits         3784     3784           
  Misses       2303     2303           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rkm rkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review only - not had a chance to check everything yet

jas88 and others added 5 commits May 29, 2024 10:30
Correct parser test is checking extraction key against expected value, rather than itself.
Trust CommandLineParser not to give us nulls for ProjectId
@jas88 jas88 requested a review from rkm May 29, 2024 15:55
jas88 and others added 2 commits May 29, 2024 12:55
Test projectid validation with blank values since compiler checks for nulls now
Copy link
Member

@rkm rkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this, @jas88 !

@rkm rkm enabled auto-merge May 29, 2024 20:39
@rkm rkm merged commit 81b6d22 into main May 29, 2024
19 checks passed
@rkm rkm deleted the feature/nunit-api branch May 29, 2024 20:59
This was referenced Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add NUnit.Analyzers package
2 participants