-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nunit api #1834
Feature/nunit api #1834
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
=======================================
Coverage 59.79% 59.79%
=======================================
Files 177 177
Lines 6328 6328
Branches 870 870
=======================================
Hits 3784 3784
Misses 2303 2303
Partials 241 241 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review only - not had a chance to check everything yet
src/applications/Applications.ExtractImages/ExtractImagesCliOptions.cs
Outdated
Show resolved
Hide resolved
src/applications/Applications.ExtractImages/ExtractionMessageSender.cs
Outdated
Show resolved
Hide resolved
...Applications.DicomDirectoryProcessor.Tests/Applications.DicomDirectoryProcessor.Tests.csproj
Outdated
Show resolved
Hide resolved
tests/applications/Applications.ExtractImages.Tests/CohortCsvParserTests.cs
Show resolved
Hide resolved
…into feature/nunit-api
Correct parser test is checking extraction key against expected value, rather than itself.
…Directory.Build.props
Trust CommandLineParser not to give us nulls for ProjectId
Test projectid validation with blank values since compiler checks for nulls now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this, @jas88 !
Proposed Changes
Update NUnit for v4 API as preparation for NUnit version bump required for later RDMP 8.1.x.
Types of changes
What types of changes does your code introduce? Tick all that apply.
[skip ci]
Checklist
By opening this PR, I confirm that I have:
Issues
Closes #1734