Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SecurityCodeScan from IDE integration to CI run as for RDMP #1833

Merged
merged 7 commits into from
May 28, 2024

Conversation

jas88
Copy link
Member

@jas88 jas88 commented May 27, 2024

Proposed Changes

SecurityCodeScan.VS2019 not playing nicely with Visual Studio 2022. Suggest moving to run as part of CI analysis as we did for RDMP, if we want this analysis run? (It's largely web app focused anyway, but could potentially detect something useful one day?)

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

  • Closes #<issue-number>
  • ...

@jas88 jas88 requested a review from rkm May 27, 2024 20:29
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.79%. Comparing base (42c06c4) to head (4d8bc4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1833   +/-   ##
=======================================
  Coverage   59.79%   59.79%           
=======================================
  Files         177      177           
  Lines        6328     6328           
  Branches      870      870           
=======================================
  Hits         3784     3784           
  Misses       2303     2303           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jas88 jas88 requested a review from rkm May 27, 2024 22:59
@jas88 jas88 enabled auto-merge (squash) May 27, 2024 23:00
@jas88 jas88 merged commit 1189483 into main May 28, 2024
19 checks passed
@jas88 jas88 deleted the feature/codescan-ci branch May 28, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants