[perf] Call Factory::first once and cache the result in FactoryServiceProvider #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
sunxiaoguang
added a commit
to sunxiaoguang/WebErpMesv2
that referenced
this pull request
Apr 28, 2024
An optimization in SMEWebify#361 caused composer install fail without working database configuration. Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
SMEWebify
added a commit
that referenced
this pull request
Apr 28, 2024
Fix the issue introduced in #361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boot function of FactoryServiceProvider is called multiple times as it's referenced in many views. This PR tries to cache the result and use it when processing current request. The optimization saves more than a hundred queries when opening dashboard.
Closes: #362