Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't test MCCP2 example code #8

Merged
merged 1 commit into from
Jul 17, 2019
Merged

don't test MCCP2 example code #8

merged 1 commit into from
Jul 17, 2019

Conversation

yehoshuapw
Copy link
Contributor

#6 seems to fail in the tests so:
Added ignore to MCCP2 example code, as it shouldn't be tested without the feature on.
(It is possible to have the same doc twice, and only ignore without the feature on, I don't think it is worth it)

Copy link
Owner

@SLMT SLMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was just about to fix this. I think ignoring the example code for testing is ok to me.

@SLMT SLMT merged commit 48603cb into SLMT:master Jul 17, 2019
@SLMT
Copy link
Owner

SLMT commented Jul 17, 2019

I just published the new version (0.1.4). You can now see this version on crate.io.

It is my fault that I didn't check the testing result before merging the previous request. Thanks for all your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants