Enable custom port and user for mongodb + fixed typo in readme #9
Conversation
There was a problem hiding this comment.
While the affected environment variables in the docker compose file can be set explicitly and individually when running docker compose - that's the point of them, I suppose having a single environment variable that affects both would be fine in this case.
Please revert your current changes to the README.md, but instead perhaps add information about your current addition to the docker-compose.yml file?
README.md
Outdated
| docker-compose pull | ||
| docker-compose up --build |
There was a problem hiding this comment.
docker compose is the correct way to do this:
This image is taken from the official Docker documentation.
There was a problem hiding this comment.
Ok. Then the corresponding documentation for oteapi services should be updated.
There was a problem hiding this comment.
I referenced this comment in the OTEAPI Service issue here.
README.md
Outdated
| @@ -95,5 +95,5 @@ For using it with Docker, use the `--env-file .env` argument when calling `docke | |||
|
|
|||
| ## Licensing & copyright | |||
|
|
|||
| All files in this repository are [MIT licensed](LICENSE). | |||
| All files in this repository are [MIT licensed](LICENSE). | |||
There was a problem hiding this comment.
I prefer to have a new line, but not new section here. Hence the end-of-line double spaces, which does exactly this.
There was a problem hiding this comment.
OK. Such blanks at end of line are stripped off by default by many editors...
|
While you re-requested a review, no updates have been pushed from your side to fix the requested changes, so my current review still stands. |
Revert changes to README.md
|
Force-merging this with changes to README reverted. The reasons for the reversions have been given above in the reviews done in spring, but no reaction has occurred on the side of the PR responsible. |
No description provided.